Issue 1406063005: Fix a typo in pub deps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1406063005: Fix a typo in pub deps. (Closed)

Created:
5 years, 1 month ago by nweiz

Modified:
5 years, 1 month ago

Reviewers:
Bob Nystrom, kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix a typo in pub deps. Closes #1351 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/19041c9526bab631d9d62dc0943a4e0b3e17cf34

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lib/src/command/deps.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nweiz

On 2015/10/28 16:01:40, Bob Nystrom wrote: > LGTM. > > How did this not break ...

5 years, 1 month ago (2015-10-28 21:29:14 UTC) #3

nweiz

Committed patchset #1 (id:1) manually as 19041c9526bab631d9d62dc0943a4e0b3e17cf34 (presubmit successful).

5 years, 1 month ago (2015-10-28 21:29:31 UTC) #4

nweiz

5 years, 1 month ago (2015-10-28 21:48:50 UTC) #7

Message was sent while issue was closed.

On 2015/10/28 21:41:18, kevmoo wrote:
> Do we need to roll into the SDK? 1.13?

I don't believe the change that added the typo is in 1.13, so we should be fine.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages