Issue 14052010: Fix broken test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14052010: Fix broken test (Closed)

Created:
7 years, 8 months ago by Søren Gjesse

Modified:
7 years, 8 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix broken test Turned out that UnmodifiableListMixin was not public. R=kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21947

Patch Set 2 : Addressed review comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	tests/standalone/io/file_test.dart	View	1	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/14052010/diff/1/tests/standalone/io/file_test.dart File tests/standalone/io/file_test.dart (right): https://codereview.chromium.org/14052010/diff/1/tests/standalone/io/file_test.dart#newcode18 tests/standalone/io/file_test.dart:18: operator [](int index) => _value; I'd throw if ...

7 years, 8 months ago (2013-04-24 13:09:49 UTC) #2

Søren Gjesse

https://codereview.chromium.org/14052010/diff/1/tests/standalone/io/file_test.dart File tests/standalone/io/file_test.dart (right): https://codereview.chromium.org/14052010/diff/1/tests/standalone/io/file_test.dart#newcode18 tests/standalone/io/file_test.dart:18: operator [](int index) => _value; On 2013/04/24 13:09:49, kustermann ...

7 years, 8 months ago (2013-04-24 13:11:53 UTC) #3

Søren Gjesse

7 years, 8 months ago (2013-04-24 13:13:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21947 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14052010: Fix broken test (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages