Issue 14051007: Allow multiple tags in native clause.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14051007: Allow multiple tags in native clause. (Closed)

Created:
7 years, 8 months ago by sra1

Modified:
7 years, 8 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow multiple tags in native clause. This simplifies, but does not allow us to get rid of, the typeNameOf functions. The '*' is no longer necessary, so native "*DOMWindow" becomes native "Window,DOMWindow". Committed: https://code.google.com/p/dart/source/detail?r=21843

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+569 lines, -582 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart	View	5 chunks	+7 lines, -17 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/native_helper.dart	View	4 chunks	+0 lines, -11 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	317 chunks	+317 lines, -317 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	12 chunks	+12 lines, -12 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	143 chunks	+143 lines, -143 lines	0 comments	Download
M	sdk/lib/typeddata/dart2js/typeddata_dart2js.dart	View	12 chunks	+12 lines, -12 lines	0 comments	Download
M	sdk/lib/web_audio/dart2js/web_audio_dart2js.dart	View	27 chunks	+27 lines, -27 lines	0 comments	Download
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View	27 chunks	+27 lines, -27 lines	0 comments	Download
M	sdk/lib/web_sql/dart2js/web_sql_dart2js.dart	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	2 chunks	+14 lines, -6 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

7 years, 8 months ago (2013-04-22 21:41:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21843 (presubmit successful).

Expand Messages | Collapse Messages