Issue 14051005: Remove deprecated CollectionSink and Stream.pipeInto.

Issue 14051005: Remove deprecated CollectionSink and Stream.pipeInto. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen

Modified:
7 years, 8 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove deprecated CollectionSink and Stream.pipeInto. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21261

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -134 lines)			Patch
M	pkg/http/lib/src/multipart_request.dart	View	1	4 chunks	+17 lines, -21 lines	0 comments	Download
M	sdk/lib/async/async_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	sdk/lib/async/collection_sink.dart	View		1 chunk	+0 lines, -51 lines	0 comments	Download
M	sdk/lib/async/stream.dart	View		1 chunk	+0 lines, -17 lines	0 comments	Download
M	tests/lib/async/stream_controller_async_test.dart	View		2 chunks	+0 lines, -32 lines	0 comments	Download
M	tests/lib/async/stream_controller_test.dart	View		1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/14051005/diff/1/pkg/http/lib/src/multipart_request.dart File pkg/http/lib/src/multipart_request.dart (right): https://codereview.chromium.org/14051005/diff/1/pkg/http/lib/src/multipart_request.dart#newcode46 pkg/http/lib/src/multipart_request.dart:46: int get contentLength { Could you move these ...

7 years, 8 months ago (2013-04-11 09:29:13 UTC) #2

Anders Johnsen

https://codereview.chromium.org/14051005/diff/1/pkg/http/lib/src/multipart_request.dart File pkg/http/lib/src/multipart_request.dart (right): https://codereview.chromium.org/14051005/diff/1/pkg/http/lib/src/multipart_request.dart#newcode46 pkg/http/lib/src/multipart_request.dart:46: int get contentLength { On 2013/04/11 09:29:13, Lasse Reichstein ...

7 years, 8 months ago (2013-04-11 09:31:26 UTC) #3

Anders Johnsen

7 years, 8 months ago (2013-04-11 09:32:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21261 (presubmit successful).

Expand Messages | Collapse Messages