Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 14049034: Revert "Revert "Fix x.runtimeType for native classes"" (Closed)

Created:
7 years, 8 months ago by sra1
Modified:
7 years, 8 months ago
Reviewers:
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Revert "Fix x.runtimeType for native classes"" Fix dummy compiler to contain Interceptor with operator== Committed: https://code.google.com/p/dart/source/detail?r=21985

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -26 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 3 chunks +7 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/core_patch.dart View 2 chunks +2 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_rti.dart View 2 chunks +6 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +16 lines, -10 lines 0 comments Download
A tests/compiler/dart2js_native/runtimetype_test.dart View 1 chunk +65 lines, -0 lines 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
Committed patchset #2 manually as r21985 (presubmit successful).
7 years, 8 months ago (2013-04-24 21:05:58 UTC) #1
karlklose
7 years, 8 months ago (2013-04-25 08:33:13 UTC) #2
Message was sent while issue was closed.
Is the change in dummy_compiler_test the only difference to the original CL?

Powered by Google App Engine
This is Rietveld 408576698