Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14049009: Rename Invocation to InvocationMirror. (Closed)

Created:
7 years, 8 months ago by ahe
Modified:
7 years, 8 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org, gbracha, Johnni Winther, erikcorry, floitsch
Visibility:
Public.

Description

Rename InvocationMirror to Invocation. Committed: https://code.google.com/p/dart/source/detail?r=21465

Patch Set 1 #

Patch Set 2 : Update file lists and co19 status #

Patch Set 3 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -94 lines) Patch
M dart/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M dart/pkg/pkg.status View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M dart/pkg/unittest/lib/mock.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/lib/invocation_mirror_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/lib/object_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/vm/dart_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/vm/stack_frame_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/vm/stub_code_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M dart/runtime/vm/stub_code_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/core_patch.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/core/core.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/core/corelib_sources.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
A + dart/sdk/lib/core/invocation.dart View 1 chunk +1 line, -1 line 0 comments Download
D dart/sdk/lib/core/invocation_mirror.dart View 1 chunk +0 lines, -52 lines 0 comments Download
M dart/sdk/lib/core/object.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/co19/co19-runtime.status View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M dart/tests/compiler/dart2js_extra/dart2js_extra.status View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/compiler/dart2js_extra/no_such_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/invocation_mirror_invoke_on_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/invocation_mirror_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M dart/tests/language/no_such_method2_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/no_such_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/overridden_no_such_method.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/super_call4_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M dart/tests/language/super_getter_setter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/super_operator_index5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/super_operator_index6_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/language/super_operator_index7_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
7 years, 8 months ago (2013-04-15 14:15:50 UTC) #1
ngeoffray
LGTM
7 years, 8 months ago (2013-04-15 14:20:25 UTC) #2
ahe
7 years, 8 months ago (2013-04-15 14:25:15 UTC) #3
ahe
Committed patchset #3 manually as r21465 (presubmit successful).
7 years, 8 months ago (2013-04-15 15:43:18 UTC) #4
Ivan Posva
7 years, 8 months ago (2013-04-15 16:50:56 UTC) #5
Message was sent while issue was closed. 
On 2013/04/15 15:43:18, ahe wrote:
> Committed patchset #3 manually as r21465 (presubmit successful).

In the future please make sure to include somebody from the VM team so that we
know what is going on in our code!

Thanks,
-Ivan

Powered by Google App Engine
This is Rietveld 408576698