Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 14048002: Make the analyzer happy about collections. (Closed)

Created:
7 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make the analyzer happy about collections. Fix some typing issues and a few real errors. Committed: https://code.google.com/p/dart/source/detail?r=21194

Patch Set 1 #

Patch Set 2 : Add missing members of ListMixin #

Patch Set 3 : Reupload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -143 lines) Patch
M sdk/lib/collection/hash_set.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/collection/list.dart View 1 3 chunks +14 lines, -3 lines 0 comments Download
M sdk/lib/collection/splay_tree.dart View 6 chunks +16 lines, -9 lines 0 comments Download
M sdk/lib/core/list.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
tests/corelib/collection_removes_test.dart View 1 2 chunks +19 lines, -0 lines 0 comments Download
M tests/corelib/list_test.dart View 1 1 chunk +138 lines, -131 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 8 months ago (2013-04-10 11:11:20 UTC) #1
floitsch
LGTM.
7 years, 8 months ago (2013-04-10 11:22:56 UTC) #2
Lasse Reichstein Nielsen
7 years, 8 months ago (2013-04-10 11:31:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r21194 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698