Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 14042012: More fixes. Thanks to Slava for reminding me of check-function-fingerprints flag. (Closed)

Created:
7 years, 8 months ago by Mads Ager (google)
Modified:
7 years, 8 months ago
Reviewers:
floitsch, srdjan, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

More fixes. Thanks to Slava for reminding me of check-function-fingerprints flag. R=asiva@google.com, floitsch@google.com, srdjan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/list_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
7 years, 8 months ago (2013-04-23 12:23:20 UTC) #1
Mads Ager (google)
Committed patchset #1 manually as r21875 (presubmit successful).
7 years, 8 months ago (2013-04-23 12:23:35 UTC) #2
srdjan
7 years, 8 months ago (2013-04-23 16:03:50 UTC) #3
srdjan
7 years, 8 months ago (2013-04-23 16:03:57 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698