Issue 14040005: Little more host-checked mode on dart2js build bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14040005: Little more host-checked mode on dart2js build bots. (Closed)

Created:
7 years, 8 months ago by ahe

Modified:
7 years, 8 months ago

Reviewers:
ricow1, kasperl

CC:
reviews_dartlang.org, kustermann

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Little more host-checked mode on dart2js build bots. Committed: https://code.google.com/p/dart/source/detail?r=21344

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	dart/tools/bots/compiler.py	View		2 chunks	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

I'll monitor test cycle time to ensure this doesn't have a huge impact.

7 years, 8 months ago (2013-04-12 10:32:56 UTC) #1

ahe

Committed patchset #1 manually as r21344 (presubmit successful).

7 years, 8 months ago (2013-04-12 10:35:06 UTC) #3

ricow1

7 years, 8 months ago (2013-04-12 10:39:55 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14040005/diff/1/dart/tools/bots/compiler.py
File dart/tools/bots/compiler.py (right):

https://codereview.chromium.org/14040005/diff/1/dart/tools/bots/compiler.py#n...
dart/tools/bots/compiler.py:215: ['--checked'])
don't we already do this on the dart2js checked builders?

Expand Messages | Collapse Messages