Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14036014: Updating DOM code to use list mixins (Closed)

Created:
7 years, 8 months ago by blois
Modified:
7 years, 7 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Updating DOM code to use list mixins BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=22512

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3458 lines, -14115 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 4 37 chunks +2596 lines, -6590 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 35 chunks +747 lines, -4741 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 2 3 4 12 chunks +6 lines, -1106 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 2 3 4 12 chunks +6 lines, -1106 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 2 3 2 chunks +1 line, -186 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 2 3 2 chunks +1 line, -186 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 2 3 4 3 chunks +11 lines, -4 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
A tools/dom/src/ImmutableListMixin.dart View 1 2 1 chunk +77 lines, -0 lines 0 comments Download
M tools/dom/templates/dart2js_impl.darttemplate View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/dart_implementation.darttemplate View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_TouchList.darttemplate View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/immutable_list_mixin.darttemplate View 1 2 3 1 chunk +0 lines, -193 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
Appears to be working now, adds ~40k to Swarm.
7 years, 8 months ago (2013-04-24 18:02:56 UTC) #1
sra1
The order of ListMixin and ImmutableListMixin varies class to class. This may explain why things ...
7 years, 8 months ago (2013-04-24 20:01:01 UTC) #2
blois
Fixed, and appears to be working? https://codereview.chromium.org/14036014/diff/14001/tools/dom/scripts/systemhtml.py File tools/dom/scripts/systemhtml.py (right): https://codereview.chromium.org/14036014/diff/14001/tools/dom/scripts/systemhtml.py#newcode524 tools/dom/scripts/systemhtml.py:524: mixins_str = ' ...
7 years, 8 months ago (2013-04-26 21:02:34 UTC) #3
sra1
lgtm
7 years, 8 months ago (2013-04-26 22:42:13 UTC) #4
blois
7 years, 7 months ago (2013-05-08 15:45:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #5 manually as r22512 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698