Issue 14034011: Ensure that type of the AssertAssignable instruction is recomputed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14034011: Ensure that type of the AssertAssignable instruction is recomputed. (Closed)

Created:
7 years, 8 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 8 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ensure that type of the AssertAssignable instruction is recomputed. If the previous type was more specific than destination type but new value type is not than we need to update outgoing type to be destination type. Otherwise a stale more specific type will be flowing out. BUG=dart:10094 R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=21809

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -5 lines)			Patch
	M	runtime/vm/flow_graph_type_propagator.cc	View		1 chunk	+3 lines, -5 lines	0 comments	Download
	A	tests/language/type_propagation_assert_assignable_test.dart	View		1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

7 years, 8 months ago (2013-04-22 12:30:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21809 (presubmit successful).

Expand Messages | Collapse Messages