Issue 14031035: Cleanup implementation of SmiToDouble to use unboxed double result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14031035: Cleanup implementation of SmiToDouble to use unboxed double result. (Closed)

Created:
7 years, 8 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Cleanup implementation of SmiToDouble to use unboxed double result. Allow CSE to eliminate redundant SmiToDouble, DoubleToDouble, InvokeMathCFunction instructions. R=srdjan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22078

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -68 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	2 chunks	+10 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		3 chunks	+20 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	2 chunks	+10 lines, -28 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+10 lines, -27 lines	0 comments	Download

Total messages: 5 (0 generated)

Vyacheslav Egorov (Google)

Please take another look. There was a bug: SmiToDouble was generated at polymorphic call sites ...

7 years, 8 months ago (2013-04-26 18:03:38 UTC) #3

Vyacheslav Egorov (Google)

7 years, 8 months ago (2013-04-26 18:11:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r22078 (presubmit successful).