Issue 140303008: Fairly partition work in tools/full-coverage.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140303008: Fairly partition work in tools/full-coverage.dart. (Closed)

Created:
6 years, 10 months ago by rmacnak

Modified:
6 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fairly partition work in tools/full-coverage.dart. BUG=http://dartbug.com/16505 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32404

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	tools/full-coverage.dart	View	1 2	2 chunks	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -ip https://codereview.chromium.org/140303008/diff/30001/tools/full-coverage.dart File tools/full-coverage.dart (right): https://codereview.chromium.org/140303008/diff/30001/tools/full-coverage.dart#newcode300 tools/full-coverage.dart:300: var leftover = list.length - (bucketSize * ...

6 years, 10 months ago (2014-02-07 00:21:00 UTC) #2

rmacnak

https://codereview.chromium.org/140303008/diff/30001/tools/full-coverage.dart File tools/full-coverage.dart (right): https://codereview.chromium.org/140303008/diff/30001/tools/full-coverage.dart#newcode300 tools/full-coverage.dart:300: var leftover = list.length - (bucketSize * nBuckets); On ...

6 years, 10 months ago (2014-02-07 02:26:49 UTC) #3

rmacnak

6 years, 10 months ago (2014-02-07 02:28:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r32404 (presubmit successful).

Expand Messages | Collapse Messages

Issue 140303008: Fairly partition work in tools/full-coverage.dart. (Closed)

Description

Patch Set 1 #

Patch Set 2 : whitespace #

Patch Set 3 : #

Messages