Chromium Code Reviews

Issue 14028017: Remove .writeStream, .consume and rewrite IOSink to correctly implement a (sane) well-defined behav… (Closed)

Created:
7 years, 8 months ago by Anders Johnsen
Modified:
7 years, 8 months ago
Reviewers:
Søren Gjesse, Lasse Reichstein Nielsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove .writeStream, .consume and rewrite IOSink to correctly implement a (sane) well-defined behaviour of the .done future. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21416

Patch Set 1 #

Patch Set 2 : Add new test file. #

Total comments: 24

Patch Set 3 : Review comments. #

Unified diffs Side-by-side diffs Stats (+434 lines, -409 lines)
M pkg/http/test/safe_http_server.dart View 1 chunk +2 lines, -4 lines 0 comments
M pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart View 1 chunk +1 line, -5 lines 0 comments
M runtime/bin/socket_patch.dart View 9 chunks +30 lines, -62 lines 0 comments
M sdk/lib/async/stream.dart View 2 chunks +1 line, -9 lines 0 comments
M sdk/lib/async/timer.dart View 2 chunks +4 lines, -7 lines 0 comments
M sdk/lib/io/file.dart View 1 chunk +2 lines, -2 lines 0 comments
M sdk/lib/io/file_impl.dart View 3 chunks +4 lines, -8 lines 0 comments
M sdk/lib/io/http.dart View 2 chunks +2 lines, -3 lines 0 comments
M sdk/lib/io/http_impl.dart View 17 chunks +170 lines, -144 lines 0 comments
M sdk/lib/io/http_parser.dart View 2 chunks +3 lines, -7 lines 0 comments
M sdk/lib/io/io_sink.dart View 4 chunks +89 lines, -136 lines 0 comments
M sdk/lib/io/process.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/io/socket.dart View 1 chunk +1 line, -2 lines 0 comments
M sdk/lib/io/stdio.dart View 1 chunk +0 lines, -2 lines 0 comments
M tests/standalone/io/http_server_response_test.dart View 3 chunks +4 lines, -4 lines 0 comments
A tests/standalone/io/io_sink_test.dart View 1 chunk +109 lines, -0 lines 0 comments
M tests/standalone/io/stdout_stderr_test.dart View 1 chunk +8 lines, -6 lines 0 comments
M tests/standalone/io/stream_pipe_test.dart View 2 chunks +3 lines, -3 lines 0 comments
M utils/pub/safe_http_server.dart View 1 chunk +0 lines, -4 lines 0 comments

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 8 months ago (2013-04-12 20:58:20 UTC) #1
Søren Gjesse
LGTM! https://codereview.chromium.org/14028017/diff/2001/pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart File pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart (right): https://codereview.chromium.org/14028017/diff/2001/pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart#newcode1 pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart:1: // iopyright (c) 2013, the Dart project authors. ...
7 years, 8 months ago (2013-04-15 06:56:30 UTC) #2
Anders Johnsen
https://codereview.chromium.org/14028017/diff/2001/pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart File pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart (right): https://codereview.chromium.org/14028017/diff/2001/pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart#newcode1 pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart:1: // iopyright (c) 2013, the Dart project authors. Please ...
7 years, 8 months ago (2013-04-15 07:35:19 UTC) #3
Anders Johnsen
7 years, 8 months ago (2013-04-15 07:36:07 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r21416 (presubmit successful).

Powered by Google App Engine