Issue 140233002: Fix issue 16103 (VM crash): incorrect merging of sin/cos.

Issue 140233002: Fix issue 16103 (VM crash): incorrect merging of sin/cos. (Closed)

Created:
6 years, 11 months ago by srdjan

Modified:
6 years, 11 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 16103: incorrect merging of sin/cos. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31858

Patch Set 3 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View	1 2	1 chunk	+8 lines, -4 lines	0 comments	Download
	M	tests/language/arithmetic_test.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with small nits. https://codereview.chromium.org/140233002/diff/50001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/140233002/diff/50001/runtime/vm/flow_graph_optimizer.cc#newcode424 runtime/vm/flow_graph_optimizer.cc:424: // Replace with TruncDivMod. Comment ...

6 years, 11 months ago (2014-01-15 23:06:19 UTC) #2

srdjan

https://codereview.chromium.org/140233002/diff/50001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/140233002/diff/50001/runtime/vm/flow_graph_optimizer.cc#newcode424 runtime/vm/flow_graph_optimizer.cc:424: // Replace with TruncDivMod. On 2014/01/15 23:06:19, Cutch wrote: ...

6 years, 11 months ago (2014-01-15 23:08:23 UTC) #3

srdjan

6 years, 11 months ago (2014-01-15 23:12:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r31858 (presubmit successful).

Expand Messages | Collapse Messages