Move Iterable implementation to collection.

Move Iterable implementation to collection.

Add IterableMixin and IterableBase to dart:collection.
For now, the implementation is duplicated, because mixins and const
constructors don't mix. We hope that mixins will be improved in the
future to allow using the mixin to define the base class.

Committed: https://code.google.com/p/dart/source/detail?r=21457

[Lasse Reichstein Nielsen, 2013-04-11 14:19:48]

There is still something fishy with a VM socket test. I have no idea why, except
for some mixin incompatibility.

[floitsch, 2013-04-11 14:24:57]

LGTM.

https://codereview.chromium.org/14022007/diff/1/sdk/lib/core/iterable.dart
File sdk/lib/core/iterable.dart (right):

https://codereview.chromium.org/14022007/diff/1/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:98: * Reduce a collection to a single value by
iteratively combining each element
Reduces

https://codereview.chromium.org/14022007/diff/1/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:118: * Convert each element to a [String] and
concatenate the strings.
Converts ... concatenates ...

https://codereview.chromium.org/14022007/diff/1/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:137: * Create a [List] containing the elements of
this [Iterable].
Creates

https://codereview.chromium.org/14022007/diff/1/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:145: * Create a [Set] containing the elements of this
[Iterable].
Creates

[floitsch, 2013-04-11 14:34:55]

Added srdjan.

[floitsch, 2013-04-11 14:40:31]

On 2013/04/11 14:34:55, floitsch wrote:
> Added srdjan.

Don't forget to update the benchmarks. There are ~20 places where it needs to
change from "extends Iterable" to "extends IterableBase".

[Lasse Reichstein Nielsen, 2013-04-11 15:57:37]

On 2013/04/11 14:40:31, floitsch wrote:
> On 2013/04/11 14:34:55, floitsch wrote:
> > Added srdjan.
> 
> Don't forget to update the benchmarks. There are ~20 places where it needs to
> change from "extends Iterable" to "extends IterableBase".

ACK. Can't do that until Monday.

[floitsch, 2013-04-13 00:25:51]

This CL breaks set.where: Unhandled exception:
Class 'HashSet' has no instance method 'where'.

[floitsch, 2013-04-13 00:26:36]

On 2013/04/13 00:25:51, floitsch wrote:
> This CL breaks set.where: Unhandled exception:
> Class 'HashSet' has no instance method 'where'.

Might be because I did a bad merge after the Collection CL (which removed the
Collection classes).
But be careful.

[Lasse Reichstein Nielsen, 2013-04-15 13:10:57]

I don't think you did anything wrong, but the CL's are slightly incompatible.
You made Set extend Iterable, and I removed implementation from Iterable.

[Lasse Reichstein Nielsen, 2013-04-15 14:19:49]

https://codereview.chromium.org/14022007/diff/1/sdk/lib/core/iterable.dart
File sdk/lib/core/iterable.dart (right):

https://codereview.chromium.org/14022007/diff/1/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:98: * Reduce a collection to a single value by
iteratively combining each element
On 2013/04/11 14:24:57, floitsch wrote:
> Reduces

Done.

https://codereview.chromium.org/14022007/diff/1/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:118: * Convert each element to a [String] and
concatenate the strings.
On 2013/04/11 14:24:57, floitsch wrote:
> Converts ... concatenates ...

Done.

https://codereview.chromium.org/14022007/diff/1/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:137: * Create a [List] containing the elements of
this [Iterable].
On 2013/04/11 14:24:57, floitsch wrote:
> Creates

Done.

https://codereview.chromium.org/14022007/diff/1/sdk/lib/core/iterable.dart#ne...
sdk/lib/core/iterable.dart:145: * Create a [Set] containing the elements of this
[Iterable].
On 2013/04/11 14:24:57, floitsch wrote:
> Creates

Done.

[Lasse Reichstein Nielsen, 2013-04-15 14:33:05]

Committed patchset #3 manually as r21457 (presubmit successful).