Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 140213003: - Large constants need to be marked as such. (Closed)

Created:
6 years, 11 months ago by Ivan Posva
Modified:
6 years, 11 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Large constants need to be marked as such. Committed: https://code.google.com/p/dart/source/detail?r=31861

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/lib/math.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
Committed patchset #2 manually as r31861 (presubmit successful).
6 years, 11 months ago (2014-01-16 00:09:19 UTC) #1
Ivan Posva
TBR
6 years, 11 months ago (2014-01-16 00:09:49 UTC) #2
srdjan
6 years, 11 months ago (2014-01-16 00:12:23 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698