Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 14018018: Support Float32x4List in the embedding API. (Closed)

Created:
7 years, 8 months ago by Mads Ager (google)
Modified:
7 years, 8 months ago
Reviewers:
Cutch, siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support Float32x4List in the embedding API. This allows Dartium to use Float32x4List arguments to the webgl uniform4fv methods. R=asiva@google.com, iposva@google.com, johnmccutchan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -12 lines) Patch
M runtime/include/dart_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 3 chunks +25 lines, -12 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +49 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
7 years, 8 months ago (2013-04-15 18:33:37 UTC) #1
Ivan Posva
LGTM -ip
7 years, 8 months ago (2013-04-15 18:36:18 UTC) #2
Mads Ager (google)
7 years, 8 months ago (2013-04-15 18:58:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21496 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698