Issue 14014004: Use name to sort IDB interfaces into the indexed_db library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14014004: Use name to sort IDB interfaces into the indexed_db library. (Closed)

Created:
7 years, 8 months ago by Mads Ager (google)

Modified:
7 years, 8 months ago

Reviewers:
Anton Muhin, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use name to sort IDB interfaces into the indexed_db library. R=antonm@google.com,blois@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21214

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	tools/dom/scripts/htmlrenamer.py	View		1 chunk	+5 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm https://codereview.chromium.org/14014004/diff/1/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (right): https://codereview.chromium.org/14014004/diff/1/tools/dom/scripts/htmlrenamer.py#newcode709 tools/dom/scripts/htmlrenamer.py:709: if interface.id.startswith("IDB"): Ugh. I imagine this is going ...

7 years, 8 months ago (2013-04-10 15:45:13 UTC) #2

Mads Ager (google)

https://codereview.chromium.org/14014004/diff/1/tools/dom/scripts/htmlrenamer.py File tools/dom/scripts/htmlrenamer.py (right): https://codereview.chromium.org/14014004/diff/1/tools/dom/scripts/htmlrenamer.py#newcode709 tools/dom/scripts/htmlrenamer.py:709: if interface.id.startswith("IDB"): On 2013/04/10 15:45:13, blois wrote: > Ugh. ...

7 years, 8 months ago (2013-04-10 16:10:04 UTC) #3

Mads Ager (google)

7 years, 8 months ago (2013-04-10 16:10:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21214 (presubmit successful).

Expand Messages | Collapse Messages