Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 14012005: Implement rethrow statement (Closed)

Created:
7 years, 8 months ago by hausner
Modified:
7 years, 8 months ago
Reviewers:
kasperl, Ivan Posva
CC:
reviews_dartlang.org, kasperl, ngeoffray
Visibility:
Public.

Description

Implement rethrow statement Or: how to turn a 5 minute task into a 2 hour ordeal. The actual business of the change is one line in token.h and one line in parser.cc. Committed: https://code.google.com/p/dart/source/detail?r=21371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -68 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +12 lines, -12 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier.h View 3 chunks +41 lines, -41 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +15 lines, -7 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/token.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/rethrow_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 8 months ago (2013-04-11 23:11:41 UTC) #1
kasperl
[cc: Nicolas]
7 years, 8 months ago (2013-04-12 06:22:52 UTC) #2
Ivan Posva
LGTM -ip
7 years, 8 months ago (2013-04-12 16:30:22 UTC) #3
hausner
7 years, 8 months ago (2013-04-12 16:32:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21371 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698