Issue 14004003: Avoid yet another import of dart:_collection_dev in the core patch library. Use the prefix _collect…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14004003: Avoid yet another import of dart:_collection_dev in the core patch library. Use the prefix _collect… (Closed)

Created:
7 years, 8 months ago by siva

Modified:
7 years, 7 months ago

Reviewers:
ahe, floitsch

CC:
reviews_dartlang.org, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Avoid yet another import of dart:_collection_dev in the core patch library. Use the prefix _collection_dev (already set up in dart:core imports) when accessing Symbol in the core patch library. R=ahe@google.com, floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=22128

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	runtime/lib/core_patch.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	runtime/lib/function_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

ahe

LGTM I think this is an example of how hard it is to please everyone. ...

7 years, 7 months ago (2013-04-29 13:20:48 UTC) #3

siva

7 years, 7 months ago (2013-04-29 16:24:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22128 (presubmit successful).