Take a broader approach to filtering out bogus Mac OS watcher events.

Take a broader approach to filtering out bogus Mac OS watcher events.

With luck, this should unflake the test.

R=rnystrom@google.com
BUG=16079
Committed: https://code.google.com/p/dart/source/detail?r=31853

[Bob Nystrom, 2014-01-15 21:32:30]

Couple of tweaks then LGTM.

https://codereview.chromium.org/140013002/diff/1/pkg/watcher/lib/src/director...
File pkg/watcher/lib/src/directory_watcher/mac_os.dart (right):

https://codereview.chromium.org/140013002/diff/1/pkg/watcher/lib/src/director...
pkg/watcher/lib/src/directory_watcher/mac_os.dart:93: _listDir().then((_) =>
print("[$_id] finished initial directory list")),
Wrap this print in a debug check.

https://codereview.chromium.org/140013002/diff/1/pkg/watcher/lib/src/director...
pkg/watcher/lib/src/directory_watcher/mac_os.dart:141: // Cancel the timer
because this batch is the only batch of bogus events
Reword more like "because bogus events only appear in the first batch."

[nweiz, 2014-01-15 21:49:17]

https://codereview.chromium.org/140013002/diff/1/pkg/watcher/lib/src/director...
File pkg/watcher/lib/src/directory_watcher/mac_os.dart (right):

https://codereview.chromium.org/140013002/diff/1/pkg/watcher/lib/src/director...
pkg/watcher/lib/src/directory_watcher/mac_os.dart:93: _listDir().then((_) =>
print("[$_id] finished initial directory list")),
On 2014/01/15 21:32:31, Bob Nystrom wrote:
> Wrap this print in a debug check.

Done.

https://codereview.chromium.org/140013002/diff/1/pkg/watcher/lib/src/director...
pkg/watcher/lib/src/directory_watcher/mac_os.dart:141: // Cancel the timer
because this batch is the only batch of bogus events
On 2014/01/15 21:32:31, Bob Nystrom wrote:
> Reword more like "because bogus events only appear in the first batch."

Done.

[nweiz, 2014-01-15 21:49:36]

Committed patchset #2 manually as r31853 (presubmit successful).