Issue 139993008: Additional refactoring for docgen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139993008: Additional refactoring for docgen. (Closed)

Created:
6 years, 10 months ago by Emily Fortuna

Modified:
6 years, 10 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Additional refactoring for docgen.` BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=32305

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+309 lines, -160 lines)			Patch
	M	pkg/docgen/bin/docgen.dart	View	1	2 chunks	+8 lines, -1 line	0 comments	Download
	M	pkg/docgen/lib/docgen.dart	View	1	48 chunks	+301 lines, -159 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Currently working on adding the cloning functionality. That will come as another patch on top ...

6 years, 10 months ago (2014-01-31 02:25:39 UTC) #1

Alan Knight

LGTM with one comment nit. https://codereview.chromium.org/139993008/diff/70001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/139993008/diff/70001/pkg/docgen/lib/docgen.dart#newcode208 pkg/docgen/lib/docgen.dart:208: /// Yes, everything in ...

6 years, 10 months ago (2014-01-31 17:48:53 UTC) #2

Emily Fortuna

care to take one more review pass over? I updated it so that you can ...

6 years, 10 months ago (2014-02-01 02:06:48 UTC) #3

Emily Fortuna

6 years, 10 months ago (2014-02-05 00:50:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r32305 (presubmit successful).

Expand Messages | Collapse Messages

Issue 139993008: Additional refactoring for docgen. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages