Issue 13998008: Add support for even more typed data on native ports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13998008: Add support for even more typed data on native ports (Closed)

Created:
7 years, 8 months ago by Søren Gjesse

Modified:
7 years, 8 months ago

Reviewers:
Anders Johnsen, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for even more typed data on native ports The only types missing now are: Float32x4, Float32x4List and Uint32x4 (currently no Uint32x4List). R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21455

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+330 lines, -20 lines)			Patch
M	runtime/bin/file.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/include/dart_api.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_message.cc	View	7 chunks	+48 lines, -19 lines	0 comments	Download
M	sdk/lib/io/common.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	1 chunk	+3 lines, -1 line	1 comment	Download
M	tests/standalone/io/file_typed_data_test.dart	View	2 chunks	+256 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #1 manually as r21455 (presubmit successful).

7 years, 8 months ago (2013-04-15 14:19:58 UTC) #3

Anders Johnsen

7 years, 8 months ago (2013-04-15 15:46:17 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/13998008/diff/1/sdk/lib/io/file_impl.dart
File sdk/lib/io/file_impl.dart (right):

https://codereview.chromium.org/13998008/diff/1/sdk/lib/io/file_impl.dart#new...
sdk/lib/io/file_impl.dart:816: if ((buffer is !List && buffer is !ByteData) ||
DBC: I believe this is wrong. We should not support ByteData here, but only any
List<int> implementing view of a ByteData. A ByteData will also fail in checked
mode, as it's not a List<int>.

Expand Messages | Collapse Messages