Issue 13994008: - Add OS::StrNDup instead of redefining it when needed.

Issue 13994008: - Add OS::StrNDup instead of redefining it when needed. (Closed)

Created:
7 years, 8 months ago by Ivan Posva

Modified:
7 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, ricow1, siva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Add OS::StrNDup instead of redefining it when needed. Committed: https://code.google.com/p/dart/source/detail?r=21368

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -32 lines)			Patch
M	runtime/platform/globals.h	View		1 chunk	+0 lines, -30 lines	0 comments	Download
M	runtime/vm/isolate.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/os.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/os_android.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/os_linux.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/os_macos.cc	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
M	runtime/vm/os_win.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/13994008/diff/1/runtime/vm/os_macos.cc File runtime/vm/os_macos.cc (right): https://codereview.chromium.org/13994008/diff/1/runtime/vm/os_macos.cc#newcode156 runtime/vm/os_macos.cc:156: #else // !defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) comment does not really match ...

7 years, 8 months ago (2013-04-12 16:10:34 UTC) #2

Ivan Posva

https://codereview.chromium.org/13994008/diff/1/runtime/vm/os_macos.cc File runtime/vm/os_macos.cc (right): https://codereview.chromium.org/13994008/diff/1/runtime/vm/os_macos.cc#newcode156 runtime/vm/os_macos.cc:156: #else // !defined(__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) On 2013/04/12 16:10:34, Vyacheslav Egorov (Google) ...

7 years, 8 months ago (2013-04-12 16:18:59 UTC) #3

Ivan Posva

7 years, 8 months ago (2013-04-12 16:19:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21368 (presubmit successful).

Expand Messages | Collapse Messages