Prohibit use of dynamic when extending or implementing classes (was crashing).

Prohibit use of dynamic when extending or implementing classes (was crashing).
Added test.
Fix typos in array patch.
Cleanup factory result finalization.
Do not verify field offsets after a finalization error.
Committed: https://code.google.com/p/dart/source/detail?r=21217

[hausner, 2013-04-10 14:53:53]

LGTM.

https://codereview.chromium.org/13992002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/13992002/diff/1/runtime/vm/parser.cc#newcode3311
runtime/vm/parser.cc:3311: "class '%s' may not extend dynamic",
may not extend 'dynamic'? I'm fine either way.

https://codereview.chromium.org/13992002/diff/1/runtime/vm/parser.cc#newcode3856
runtime/vm/parser.cc:3856: ErrorMsg(interface_pos, "dynamic may not be used in
interface list");
ditto

[regis, 2013-04-10 16:31:33]

Thanks!

https://codereview.chromium.org/13992002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/13992002/diff/1/runtime/vm/parser.cc#newcode3311
runtime/vm/parser.cc:3311: "class '%s' may not extend dynamic",
On 2013/04/10 14:53:53, hausner wrote:
> may not extend 'dynamic'? I'm fine either way.

Done.

https://codereview.chromium.org/13992002/diff/1/runtime/vm/parser.cc#newcode3856
runtime/vm/parser.cc:3856: ErrorMsg(interface_pos, "dynamic may not be used in
interface list");
On 2013/04/10 14:53:53, hausner wrote:
> ditto

Done.

[regis, 2013-04-10 16:43:45]

Committed patchset #2 manually as r21217 (presubmit successful).