Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1398573002: Use task model for strong mode (Closed)

Created:
5 years, 2 months ago by vsm
Modified:
5 years, 2 months ago
Reviewers:
Paul Berry, pquitslund
CC:
reviews_dartlang.org, Leaf, danrubel
Base URL:
https://github.com/dart-lang/analyzer_cli.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use task model for strong mode This is dependent on new versions of ddc and analyzer (with leafp's latest cl) landing. I'll need to update the pubspec accordingly. R=paulberry@google.com, pquitslund@google.com Committed: https://github.com/dart-lang/analyzer_cli/commit/af40be0e3cc0b9904151a45e8074a8e797443cb6

Patch Set 1 #

Patch Set 2 : Update pubspec #

Patch Set 3 : Update version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M lib/src/driver.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M pubspec.yaml View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vsm
5 years, 2 months ago (2015-10-07 21:48:15 UTC) #2
Paul Berry
driver.dart changes lgtm.
5 years, 2 months ago (2015-10-07 21:52:28 UTC) #3
vsm
PTAL for pubspec - I'll publish if it this looks good.
5 years, 2 months ago (2015-10-08 21:09:20 UTC) #5
pquitslund
LGTM!
5 years, 2 months ago (2015-10-08 23:21:34 UTC) #6
vsm
5 years, 2 months ago (2015-10-09 12:59:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
af40be0e3cc0b9904151a45e8074a8e797443cb6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698