Issue 13985012: dart:io | Change the way SecureSocket initializes the NSS library with an empty database.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13985012: dart:io | Change the way SecureSocket initializes the NSS library with an empty database. (Closed)

Created:
7 years, 8 months ago by Bill Hesse

Modified:
7 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Change the way SecureSocket initializes the NSS library with an empty database. BUG=dartbug.com/7104 Committed: https://code.google.com/p/dart/source/detail?r=21363

Patch Set 1 #

Total comments: 3

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -22 lines)			Patch
	M	runtime/bin/secure_socket.cc	View		2 chunks	+42 lines, -20 lines	3 comments	Download
	A +	tests/standalone/io/secure_no_builtin_roots_database_test.dart	View		1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

https://codereview.chromium.org/13985012/diff/1/runtime/bin/secure_socket.cc File runtime/bin/secure_socket.cc (right): https://codereview.chromium.org/13985012/diff/1/runtime/bin/secure_socket.cc#newcode348 runtime/bin/secure_socket.cc:348: Too many spaces.

7 years, 8 months ago (2013-04-12 14:42:14 UTC) #1

Søren Gjesse

lgtm https://codereview.chromium.org/13985012/diff/1/runtime/bin/secure_socket.cc File runtime/bin/secure_socket.cc (right): https://codereview.chromium.org/13985012/diff/1/runtime/bin/secure_socket.cc#newcode337 runtime/bin/secure_socket.cc:337: static const char* builtin_roots_module = As we don't ...

7 years, 8 months ago (2013-04-12 14:59:31 UTC) #2

Bill Hesse

7 years, 8 months ago (2013-04-12 15:23:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21363 (presubmit successful).

Expand Messages | Collapse Messages