Issue 13985009: Remove proxy-related environment variables when running standalone tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13985009: Remove proxy-related environment variables when running standalone tests (Closed)

Created:
7 years, 8 months ago by kustermann

Modified:
7 years, 8 months ago

Reviewers:
ricow1, Søren Gjesse, ahe, Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove proxy-related environment variables when running standalone tests Committed: https://code.google.com/p/dart/source/detail?r=21360

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	tools/testing/dart/test_runner.dart	View		2 chunks	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

Maybe we should also strip the environment for standalone tests down to a minimum (in ...

7 years, 8 months ago (2013-04-12 12:33:36 UTC) #1

ricow1

LGTM https://codereview.chromium.org/13985009/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/13985009/diff/1/tools/testing/dart/test_runner.dart#newcode36 tools/testing/dart/test_runner.dart:36: const List<String> EXCLUDED_ENVIRONMENT_VARIABLES = Please add a statement ...

7 years, 8 months ago (2013-04-12 14:39:08 UTC) #3

kustermann

7 years, 8 months ago (2013-04-12 14:45:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21360 (presubmit successful).

Expand Messages | Collapse Messages