Issue 13985006: Make the proxy server resolution from environment variables the default for HttpClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13985006: Make the proxy server resolution from environment variables the default for HttpClient (Closed)

Created:
7 years, 8 months ago by Søren Gjesse

Modified:
7 years, 8 months ago

Reviewers:
Bob Nystrom, Mads Ager (google)

CC:
reviews_dartlang.org, nweiz, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make the proxy server resolution from environment variables the default for HttpClient In almost all situations where a HttpClient is used proxy support will be needed. Having the default be enabling proxies through environment variables will make everyones life easier. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21332

Patch Set 1 #

Patch Set 2 : Minor fix #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	sdk/lib/io/http.dart	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
	M	sdk/lib/io/http_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #2 manually as r21332 (presubmit successful).

7 years, 8 months ago (2013-04-12 08:09:01 UTC) #4

Message was sent while issue was closed.

LGTM!

Expand Messages | Collapse Messages