Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 13982012: Update pkg/serialization to use Symbols and synchronous mirrors (Closed)

Created:
7 years, 8 months ago by Alan Knight
Modified:
7 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update pkg/serialization to use Symbols and synchronous mirrors Committed: https://code.google.com/p/dart/source/detail?r=21818

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -36 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/serialization/lib/serialization.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/serialization/lib/src/basic_rule.dart View 14 chunks +68 lines, -25 lines 0 comments Download
M pkg/serialization/lib/src/mirrors_helpers.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/serialization/lib/src/serialization_rule.dart View 2 chunks +14 lines, -3 lines 0 comments Download
M pkg/serialization/test/serialization_test.dart View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alan Knight
This makes minimal changes to use Symbols and synchronous mirrors. There are definitely some follow-on ...
7 years, 8 months ago (2013-04-19 21:35:34 UTC) #1
Alan Knight
7 years, 8 months ago (2013-04-19 21:35:47 UTC) #2
Jennifer Messerly
lgtm
7 years, 8 months ago (2013-04-19 23:46:29 UTC) #3
Alan Knight
7 years, 8 months ago (2013-04-22 17:01:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21818 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698