Issue 13979009: Use native types for inlined native fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13979009: Use native types for inlined native fields. (Closed)

Created:
7 years, 8 months ago by sra1

Modified:
7 years, 8 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use native types for inlined native fields. Committed: https://code.google.com/p/dart/source/detail?r=22000

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -18 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	sdk/lib/_internal/compiler/implementation/ssa/types.dart	View	1	1 chunk	+18 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM! https://codereview.chromium.org/13979009/diff/1/sdk/lib/_internal/compiler/implementation/ssa/types.dart File sdk/lib/_internal/compiler/implementation/ssa/types.dart (left): https://codereview.chromium.org/13979009/diff/1/sdk/lib/_internal/compiler/implementation/ssa/types.dart#oldcode150 sdk/lib/_internal/compiler/implementation/ssa/types.dart:150: assert(!ssaType.isConflicting()); Want to keep this assertion?

7 years, 8 months ago (2013-04-25 05:27:29 UTC) #2

sra1

7 years, 8 months ago (2013-04-25 06:38:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22000 (presubmit successful).

Expand Messages | Collapse Messages

Issue 13979009: Use native types for inlined native fields. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages