Issue 13979006: Pass in arguments to create_sdk instead of using positional command line arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13979006: Pass in arguments to create_sdk instead of using positional command line arguments (Closed)

Created:
7 years, 8 months ago by ricow1

Modified:
7 years, 8 months ago

Reviewers:
ahe, dgrove

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Pass in arguments to create_sdk instead of using positional command line arguments Committed: https://code.google.com/p/dart/source/detail?r=21272

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	dart.gyp	View		1 chunk	+2 lines, -2 lines	1 comment	Download
	M	tools/create_sdk.py	View		4 chunks	+16 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM https://codereview.chromium.org/13979006/diff/1/dart.gyp File dart.gyp (right): https://codereview.chromium.org/13979006/diff/1/dart.gyp#newcode87 dart.gyp:87: '--utils_snapshot_location', '<(SHARED_INTERMEDIATE_DIR)' I'd prefer if this was '<(SHARED_INTERMEDIATE_DIR)/utils_wrapper.dart.snapshot'

7 years, 8 months ago (2013-04-11 09:48:43 UTC) #2

ricow1

Committed patchset #1 manually as r21272 (presubmit successful).

7 years, 8 months ago (2013-04-11 12:19:42 UTC) #3

Message was sent while issue was closed.

lgtm!

Expand Messages | Collapse Messages