Issue 13975018: More cleanups in debugger API and wire protocol

Issue 13975018: More cleanups in debugger API and wire protocol (Closed)

Created:
7 years, 8 months ago by hausner

Modified:
7 years, 8 months ago

Reviewers:
Tom Ball

CC:
reviews_dartlang.org, devoncarew

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

More cleanups in debugger API and wire protocol Committed: https://code.google.com/p/dart/source/detail?r=21392

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -56 lines)			Patch
M	runtime/bin/dbg_message.cc	View		2 chunks	+14 lines, -37 lines	0 comments	Download
M	runtime/include/dart_debugger_api.h	View	1	4 chunks	+25 lines, -8 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View		1 chunk	+10 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Tom Ball

lgtm https://codereview.chromium.org/13975018/diff/1/runtime/include/dart_debugger_api.h File runtime/include/dart_debugger_api.h (right): https://codereview.chromium.org/13975018/diff/1/runtime/include/dart_debugger_api.h#newcode54 runtime/include/dart_debugger_api.h:54: int32_t token_pos; // Code address. Line up comment? ...

7 years, 8 months ago (2013-04-12 21:44:32 UTC) #2

hausner

Thank you. https://codereview.chromium.org/13975018/diff/1/runtime/include/dart_debugger_api.h File runtime/include/dart_debugger_api.h (right): https://codereview.chromium.org/13975018/diff/1/runtime/include/dart_debugger_api.h#newcode54 runtime/include/dart_debugger_api.h:54: int32_t token_pos; // Code address. On 2013/04/12 ...

7 years, 8 months ago (2013-04-12 21:48:09 UTC) #3

hausner

7 years, 8 months ago (2013-04-12 21:49:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21392 (presubmit successful).

Expand Messages | Collapse Messages