Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13971004: - Reverting the 'static' change of strndup. (Closed)

Created:
7 years, 8 months ago by Ivan Posva
Modified:
7 years, 8 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Reverting the 'static' change of strndup. Committed: https://code.google.com/p/dart/source/detail?r=21323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/platform/globals.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
Committed patchset #1 manually as r21323 (presubmit successful).
7 years, 8 months ago (2013-04-11 23:46:18 UTC) #1
Ivan Posva
TBR Overall this approach is too fragile. I will add StrNDup to OS and dispatch ...
7 years, 8 months ago (2013-04-11 23:47:49 UTC) #2
ricow1
7 years, 8 months ago (2013-04-12 09:03:27 UTC) #3
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698