Issue 139663003: Fix 16099: Invocation's positionalArguments contains an immutable array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 139663003: Fix 16099: Invocation's positionalArguments contains an immutable array. (Closed)

Created:
6 years, 11 months ago by srdjan

Modified:
6 years, 11 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix 16099: Invocation's positionalArguments contains an immutable array. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=31845

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -4 lines)			Patch
M	runtime/lib/array.cc	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	runtime/lib/array.dart	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/lib/invocation_mirror_patch.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/139663003/diff/1/runtime/lib/array.cc File runtime/lib/array.cc (right): https://codereview.chromium.org/139663003/diff/1/runtime/lib/array.cc#newcode114 runtime/lib/array.cc:114: // Private factory, expects correct arguments. We should ...

6 years, 11 months ago (2014-01-15 18:35:08 UTC) #2

srdjan

https://codereview.chromium.org/139663003/diff/1/runtime/lib/array.cc File runtime/lib/array.cc (right): https://codereview.chromium.org/139663003/diff/1/runtime/lib/array.cc#newcode114 runtime/lib/array.cc:114: // Private factory, expects correct arguments. On 2014/01/15 18:35:09, ...

6 years, 11 months ago (2014-01-15 19:04:26 UTC) #3

srdjan

6 years, 11 months ago (2014-01-15 19:14:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r31845 (presubmit successful).

Expand Messages | Collapse Messages

Issue 139663003: Fix 16099: Invocation's positionalArguments contains an immutable array. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages