Put a snapshot of pub in the SDK.

Put a snapshot of pub in the SDK.

BUG=9117
Committed: https://code.google.com/p/dart/source/detail?r=21979

[ahe, 2013-04-24 06:47:24]

I don't understand why you're adding test and gyp files to the sdk directory.

Having a snapshot file allows us to avoid placing stuff in sdk that isn't part
of what we ship, and we're trying to move the contents sdk/lib/_internal out of
there.

Tests do not belong in sdk, they belong in the directory test, but that might be
old "damage".

You should at least move the gyp file to utils/pub.

[Bob Nystrom, 2013-04-24 16:31:36]

I know you just moved pub *into* sdk/ but given this patch, I think we should
probably move it back out. With this, we don't need pub's source in the SDK,
right?

https://codereview.chromium.org/13966011/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/13966011/diff/1/tools/create_sdk.py#newcode212
tools/create_sdk.py:212: for library in [join('_internal', 'compiler'),
join('_internal', 'dartdoc'),
Nit, but I would put each join() on its own line.

https://codereview.chromium.org/13966011/diff/1/tools/create_sdk.py#newcode232
tools/create_sdk.py:232: join(LIB, '_internal', 'libraries.dart'))
What's this about? Is this related to the pub change?

https://codereview.chromium.org/13966011/diff/1/tools/create_sdk.py#newcode287
tools/create_sdk.py:287: # Copy dart2js/dartdoc.
Update comment.

[nweiz, 2013-04-24 20:00:46]

This is probably not going to be the final location of pub; I put it here based
on an outdated bug. Dan has volunteered to move it again soon to what will
hopefully be its final location, but for the time being I'd like to submit
regardless.

I've moved pub.gyp into utils/pub.

https://codereview.chromium.org/13966011/diff/1/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/13966011/diff/1/tools/create_sdk.py#newcode212
tools/create_sdk.py:212: for library in [join('_internal', 'compiler'),
join('_internal', 'dartdoc'),
On 2013/04/24 16:31:36, Bob Nystrom wrote:
> Nit, but I would put each join() on its own line.

Done.

https://codereview.chromium.org/13966011/diff/1/tools/create_sdk.py#newcode212
tools/create_sdk.py:212: for library in [join('_internal', 'compiler'),
join('_internal', 'dartdoc'),
On 2013/04/24 16:31:36, Bob Nystrom wrote:
> Nit, but I would put each join() on its own line.

Done.

https://codereview.chromium.org/13966011/diff/1/tools/create_sdk.py#newcode232
tools/create_sdk.py:232: join(LIB, '_internal', 'libraries.dart'))
On 2013/04/24 16:31:36, Bob Nystrom wrote:
> What's this about? Is this related to the pub change?

The for loop above used to put everything under _internal into the SDK
automatically. Now it does it on a case-by-case basis, since it needs to exclude
the pub source. copytree won't work on a single file, so we need to explicitly
copy this file in here.

https://codereview.chromium.org/13966011/diff/1/tools/create_sdk.py#newcode287
tools/create_sdk.py:287: # Copy dart2js/dartdoc.
On 2013/04/24 16:31:36, Bob Nystrom wrote:
> Update comment.

Done.

[Bob Nystrom, 2013-04-24 20:13:09]

LGTM.

[nweiz, 2013-04-24 20:43:46]

Committed patchset #2 manually as r21979 (presubmit successful).