Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 13963009: Change the order of blocking in AllocateRegistersLocally. (Closed)

Created:
7 years, 8 months ago by Vyacheslav Egorov (Google)
Modified:
7 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the order of blocking in AllocateRegistersLocally. Programmer is free to specify any register as a fixed RegisterLocation even one outside of the range available to the allocator itself. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21577

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M runtime/vm/flow_graph_compiler.cc View 1 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vyacheslav Egorov (Google)
Please take a look. I did not implement safe guarding that I described to you ...
7 years, 8 months ago (2013-04-16 16:58:37 UTC) #1
Vyacheslav Egorov (Google)
wrong version was initially uploaded. now I uploaded the right one.
7 years, 8 months ago (2013-04-16 17:00:27 UTC) #2
regis
LGTM
7 years, 8 months ago (2013-04-16 17:03:12 UTC) #3
Vyacheslav Egorov (Google)
7 years, 8 months ago (2013-04-16 20:56:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21577 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698