adjust location of URI helper files for spawn_uri tests in the browser.

Fix for Anton.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=21584

[Emily Fortuna, 2013-04-11 18:21:40]

Hi Martin,
The reason for this change is Anton was working on adding spawn_uri
functionality in dartium, and realized no version of the spawn_uri tests was
actually working when we tested it in the browser because of the way the test
server serves files out of generated_tests. 

The simpler way to fix this would be to fix the URI called in the test itself,
however, these tests are intended to run both in the browser and on the command
line, so we'd have to two tests with the same functionality just with different
URI paths and run one on the command line and one in the browser, which seemed
suboptimal. So instead I am using the same test for both, but changing the
location the helper URI file is placed for the browser tests (for command line
tests, there is no wrapping, so this isn't an issue).

[kustermann, 2013-04-11 20:32:44]

https://codereview.chromium.org/13962004/diff/5001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/13962004/diff/5001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:980: fromPath.toNativePath(),
'$tempDir/../$baseName.js',
We can't do that (i.e. '..'). If multiple tests have 'otherScripts' with the
same name, we can get collisions here.

Instead you could maybe put the html file one level deeper?

https://codereview.chromium.org/13962004/diff/5001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:990:
fromFile.openRead().pipe(toFile.openWrite());
This is an asynchronous operation. It could happen that the test file is not
written at the time the test starts. Please use *sync() FileIO for this (as we
do above with 'htmlTest'.

[Emily Fortuna, 2013-04-12 18:23:07]

PTAL

[kustermann, 2013-04-15 08:02:42]

+ricow, ahe: Could you take a look as well?

https://codereview.chromium.org/13962004/diff/22001/tools/testing/dart/test_s...
File tools/testing/dart/test_suite.dart (left):

https://codereview.chromium.org/13962004/diff/22001/tools/testing/dart/test_s...
tools/testing/dart/test_suite.dart:931: String htmlFilename =
getHtmlName(filename);
the 'getHtmlName' function is no longer used.

[ahe, 2013-04-15 18:17:45]

https://codereview.chromium.org/13962004/diff/22001/tools/testing/dart/test_s...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/13962004/diff/22001/tools/testing/dart/test_s...
tools/testing/dart/test_suite.dart:959: List<String> otherScripts =
optionsFromFile['otherScripts'];
I don't understand why this is specific to browser tests.

[Emily Fortuna, 2013-04-16 18:40:16]

https://codereview.chromium.org/13962004/diff/22001/tools/testing/dart/test_s...
File tools/testing/dart/test_suite.dart (left):

https://codereview.chromium.org/13962004/diff/22001/tools/testing/dart/test_s...
tools/testing/dart/test_suite.dart:931: String htmlFilename =
getHtmlName(filename);
On 2013/04/15 08:02:42, kustermann wrote:
> the 'getHtmlName' function is no longer used.

Done.

https://codereview.chromium.org/13962004/diff/22001/tools/testing/dart/test_s...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/13962004/diff/22001/tools/testing/dart/test_s...
tools/testing/dart/test_suite.dart:959: List<String> otherScripts =
optionsFromFile['otherScripts'];
On 2013/04/15 18:17:45, ahe wrote:
> I don't understand why this is specific to browser tests.

This is specific to browser tests because they are not run from the test
directory. The browser tests create an  html file in the output directory
(generated_tests/...) and copy any relevant files (js or dart) into the output
directory. In comparison, the vm tests just run from the same location that they
were originally written.

[kustermann, 2013-04-16 19:05:38]

lgtm

The only thing I was a little nervous about is the fact that the html filenames
were previously encoded using absolut paths, now we're calling it 'test.html'
and put it inside a directory which is encoded using the relative path to the
tests -- but this should IMO be fine.

[Emily Fortuna, 2013-04-16 22:17:44]

Committed patchset #5 manually as r21584 (presubmit successful).

[ahe, 2013-07-24 09:31:40]

https://codereview.chromium.org/13962004/diff/22001/tools/testing/dart/test_s...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/13962004/diff/22001/tools/testing/dart/test_s...
tools/testing/dart/test_suite.dart:959: List<String> otherScripts =
optionsFromFile['otherScripts'];
On 2013/04/16 18:40:16, Emily Fortuna wrote:
> On 2013/04/15 18:17:45, ahe wrote:
> > I don't understand why this is specific to browser tests.
> 
> This is specific to browser tests because they are not run from the test
> directory. The browser tests create an  html file in the output directory
> (generated_tests/...) and copy any relevant files (js or dart) into the output
> directory. In comparison, the vm tests just run from the same location that
they
> were originally written.

Sorry for the late reply.

I still don't understand why this feature is specific to browser tests.  There
are other tests that get copied, in particular, multi-tests.

I think we need to make general features and avoid special casing browser tests.
 The only thing special about a browser test should be that it is running in a
browser and that need to generate an HTML file.  Everything else should be
generalized.