Issue 13959004: Compile Dart to JS in an isolate in dartdoc.

Issue 13959004: Compile Dart to JS in an isolate in dartdoc. (Closed)

Created:
7 years, 8 months ago by nweiz

Modified:
7 years, 8 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Compile Dart to JS in an isolate in dartdoc. Committed: https://code.google.com/p/dart/source/detail?r=21176

Patch Set 2 : Code review change. #

Patch Set 3 : packageRoot fix #

Patch Set 4 : Nathan's Isolate changes #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1208 lines, -111 lines)			Patch
M	sdk/bin/dartdoc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/dartdoc/bin/dartdoc.dart	View	1 2 3	7 chunks	+36 lines, -29 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	1 2 3	22 chunks	+279 lines, -36 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart	View	1 2 3	3 chunks	+85 lines, -3 lines	0 comments	Download
A	sdk/lib/_internal/dartdoc/lib/src/export_map.dart	View	1 2 3	1 chunk	+342 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/pubspec.yaml	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/test/dartdoc_test.dart	View	1 2 3	1 chunk	+0 lines, -36 lines	0 comments	Download
A	sdk/lib/_internal/dartdoc/test/export_map_test.dart	View	1 2 3	1 chunk	+400 lines, -0 lines	0 comments	Download
A	sdk/lib/_internal/dartdoc/test/utils_test.dart	View	1 2 3	1 chunk	+45 lines, -0 lines	0 comments	Download
M	utils/apidoc/apidoc.dart	View	1 2 3	8 chunks	+19 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm https://codereview.chromium.org/13959004/diff/1/sdk/lib/_internal/dartdoc/lib/dartdoc.dart File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right): https://codereview.chromium.org/13959004/diff/1/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode152 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:152: var clientScript = (message['mode'] == MODE_STATIC) ? 'static' ...

7 years, 8 months ago (2013-04-09 23:51:06 UTC) #2

nweiz

I forgot to merge in another fix; PTAL. https://codereview.chromium.org/13959004/diff/1/sdk/lib/_internal/dartdoc/lib/dartdoc.dart File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right): https://codereview.chromium.org/13959004/diff/1/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode152 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:152: var ...

7 years, 8 months ago (2013-04-09 23:53:38 UTC) #3

nweiz

7 years, 8 months ago (2013-04-09 23:58:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r21176 (presubmit successful).

Expand Messages | Collapse Messages