Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 13956028: Remove dartdoc specific methods from dart2js_mirror. (Closed)

Created:
7 years, 8 months ago by Johnni Winther
Modified:
7 years, 8 months ago
Reviewers:
ahe, Andrei Mouravski
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove dartdoc specific methods from dart2js_mirror. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21921 Committed: https://code.google.com/p/dart/source/detail?r=21924

Patch Set 1 #

Patch Set 2 : Remove comment. #

Total comments: 1

Patch Set 3 : Rebased #

Patch Set 4 : Comment added. #

Patch Set 5 : Fix call to analyze. #

Patch Set 6 : Fix test uses of analyze. #

Patch Set 7 : Remove stale comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -1782 lines) Patch
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 1 3 chunks +10 lines, -76 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/lib/src/dart2js_mirrors.dart View 1 2 3 4 5 6 3 chunks +15 lines, -1697 lines 0 comments Download
M tests/compiler/dart2js/mirrors_test.dart View 1 2 3 4 5 2 chunks +13 lines, -6 lines 0 comments Download
M tools/dom/docs/lib/docs.dart View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/html_diff.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Johnni Winther
7 years, 8 months ago (2013-04-22 13:57:02 UTC) #1
Andrei Mouravski
Please move dart2js_mirrors.dart to .../dartdoc/lib/src/dart2js_mirrors.dart It is not a library we want to expose. https://codereview.chromium.org/13956028/diff/2001/sdk/lib/_internal/dartdoc/lib/dart2js_mirrors.dart ...
7 years, 8 months ago (2013-04-22 15:25:49 UTC) #2
Johnni Winther
PTAL
7 years, 8 months ago (2013-04-24 06:08:16 UTC) #3
Andrei Mouravski
lgtm Just make sure tests pass and please try running apidocs and checking manually (since ...
7 years, 8 months ago (2013-04-24 06:13:51 UTC) #4
Johnni Winther
On 2013/04/24 06:13:51, Andrei Mouravski wrote: > lgtm > > Just make sure tests pass ...
7 years, 8 months ago (2013-04-24 06:16:44 UTC) #5
Johnni Winther
Committed patchset #5 manually as r21921 (presubmit successful).
7 years, 8 months ago (2013-04-24 06:36:33 UTC) #6
Johnni Winther
7 years, 8 months ago (2013-04-24 07:32:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #7 manually as r21924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698