Issue 13951007: Fix bug in MegamorphicCacheMissHandler: put kNullCid into the cache when receiver is null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13951007: Fix bug in MegamorphicCacheMissHandler: put kNullCid into the cache when receiver is null. (Closed)

Created:
7 years, 8 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 8 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bug in MegamorphicCacheMissHandler: put kNullCid into the cache when receiver is null. We were putting kObjectCid before causing inline lookup code to always miss when receiver is null. BUG=dart:9815 Committed: https://code.google.com/p/dart/source/detail?r=21366

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	runtime/vm/code_generator.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

7 years, 8 months ago (2013-04-12 16:03:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21366 (presubmit successful).

Expand Messages | Collapse Messages