Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 139493010: Invoke dart2js lazily when using pub serve. (Closed)

Created:
6 years, 10 months ago by nweiz
Modified:
6 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Invoke dart2js lazily when using pub serve. R=rnystrom@google.com BUG=16076 Committed: https://code.google.com/p/dart/source/detail?r=32579

Patch Set 1 #

Total comments: 1

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 10 months ago (2014-02-11 00:33:17 UTC) #1
Bob Nystrom
LGTM, but we should talk about what laziness means for error reporting. https://codereview.chromium.org/139493010/diff/1/sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_until_its_output_is_requested_test.dart File sdk/lib/_internal/pub/test/transformer/dart2js/does_not_compile_until_its_output_is_requested_test.dart ...
6 years, 10 months ago (2014-02-11 19:08:47 UTC) #2
nweiz
On 2014/02/11 19:08:47, Bob Nystrom wrote: > LGTM, but we should talk about what laziness ...
6 years, 10 months ago (2014-02-11 21:39:27 UTC) #3
nweiz
6 years, 10 months ago (2014-02-11 21:40:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r32579 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698