Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 13948009: Fix issue 9744 (Closed)

Created:
7 years, 8 months ago by hausner
Modified:
7 years, 8 months ago
Reviewers:
Tom Ball
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix issue 9744 Allow for debugger stack frames that have no corresponding pc descriptor entry, i.e. the PC is not at a known safe point. In that case, we cannot return a code location nor variables. Fixes 9744 Committed: https://code.google.com/p/dart/source/detail?r=21175

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -16 lines) Patch
M runtime/vm/debugger.cc View 7 chunks +23 lines, -6 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +5 lines, -1 line 0 comments Download
M tools/ddbg.dart View 1 5 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
Also contains a fix to make ddbg.dart run again after the library team removed close() ...
7 years, 8 months ago (2013-04-09 22:26:02 UTC) #1
Tom Ball
lgtm https://codereview.chromium.org/13948009/diff/1/tools/ddbg.dart File tools/ddbg.dart (right): https://codereview.chromium.org/13948009/diff/1/tools/ddbg.dart#newcode18 tools/ddbg.dart:18: var stdinListenerOrWhateverThisIs; It's a StreamSubscription, so maybe stdinSubscription ...
7 years, 8 months ago (2013-04-09 23:12:06 UTC) #2
hausner
Thank you. https://codereview.chromium.org/13948009/diff/1/tools/ddbg.dart File tools/ddbg.dart (right): https://codereview.chromium.org/13948009/diff/1/tools/ddbg.dart#newcode18 tools/ddbg.dart:18: var stdinListenerOrWhateverThisIs; Thanks for the hint. I ...
7 years, 8 months ago (2013-04-09 23:36:32 UTC) #3
hausner
7 years, 8 months ago (2013-04-09 23:36:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21175 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698