Issue 13942008: - Add synchronous mirror API. Resurrects invoke, apply, newInstance,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13942008: - Add synchronous mirror API. Resurrects invoke, apply, newInstance, (Closed)

Created:
7 years, 8 months ago by Ivan Posva

Modified:
7 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, gbracha, ahe

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Add synchronous mirror API. Resurrects invoke, apply, newInstance, getField and setField as synchronous calls that accept isolate-local object as arguments. Originally reviewed as https://codereview.chromium.org/14044007/ Committed: https://code.google.com/p/dart/source/detail?r=21591

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+185 lines, -30 lines)			Patch
M	runtime/lib/mirrors.cc	View	5 chunks	+56 lines, -15 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	9 chunks	+52 lines, -9 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View	3 chunks	+47 lines, -1 line	0 comments	Download
M	tests/lib/mirrors/mirrors_test.dart	View	5 chunks	+26 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Ivan Posva

7 years, 8 months ago (2013-04-16 23:19:35 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r21591 (presubmit successful).