Issue 13941003: Rewrite regress_7191 to avoid changing stream subscription.

Issue 13941003: Rewrite regress_7191 to avoid changing stream subscription. (Closed)

Created:
7 years, 8 months ago by Anders Johnsen

Modified:
7 years, 8 months ago

Reviewers:
ricow1, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix regress_7191. BUG=https://code.google.com/p/dart/issues/detail?id=8091 Committed: https://code.google.com/p/dart/source/detail?r=21133

Patch Set 2 : #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	tests/standalone/io/regress_7191_script.dart	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/standalone/io/regress_7191_test.dart	View	1	1 chunk	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

Committed patchset #2 manually as r21133 (presubmit successful).

7 years, 8 months ago (2013-04-09 07:26:11 UTC) #3

Mads Ager (google)

https://codereview.chromium.org/13941003/diff/2001/tests/standalone/io/regress_7191_test.dart File tests/standalone/io/regress_7191_test.dart (right): https://codereview.chromium.org/13941003/diff/2001/tests/standalone/io/regress_7191_test.dart#newcode26 tests/standalone/io/regress_7191_test.dart:26: process.exitCode.then((exitCode) => port.close()); We should add verification of the ...

7 years, 8 months ago (2013-04-10 06:10:38 UTC) #4

Anders Johnsen

7 years, 8 months ago (2013-04-10 11:41:32 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/13941003/diff/2001/tests/standalone/io/regres...
File tests/standalone/io/regress_7191_test.dart (right):

https://codereview.chromium.org/13941003/diff/2001/tests/standalone/io/regres...
tests/standalone/io/regress_7191_test.dart:26: process.exitCode.then((exitCode)
=> port.close());
On 2013/04/10 06:10:38, Mads Ager wrote:
> We should add verification of the exitCode here. That would have caught this
> issue because the exit code of the script was non-zero.
> 
> Anders, could you add that?

Yep, done in https://codereview.chromium.org/13851008.

Expand Messages | Collapse Messages