Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13939003: Fixed stack trace for isolates without any Dart frames. (Closed)

Created:
7 years, 8 months ago by Tom Ball
Modified:
7 years, 8 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixed stack trace for isolates without any Dart frames. Updated stats display to display empty stack dumps, and reduced screen update time. Committed: https://code.google.com/p/dart/source/detail?r=21573

Patch Set 1 #

Patch Set 2 : fixed divide-by-zero error in bargraph.dart #

Total comments: 3

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -31 lines) Patch
M runtime/bin/vmstats/bargraph.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmstats/isolate_list.dart View 1 2 3 4 chunks +31 lines, -21 lines 0 comments Download
M runtime/bin/vmstats/vmstats.css View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/bin/vmstats/vmstats.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 1 chunk +18 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Tom Ball
7 years, 8 months ago (2013-04-10 18:13:22 UTC) #1
Tom Ball
PTAL: fixed divide-by-zero error in bargraph.dart.
7 years, 8 months ago (2013-04-11 23:41:06 UTC) #2
Ivan Posva
https://codereview.chromium.org/13939003/diff/4001/runtime/vm/isolate.cc File runtime/vm/isolate.cc (right): https://codereview.chromium.org/13939003/diff/4001/runtime/vm/isolate.cc#newcode895 runtime/vm/isolate.cc:895: ml.Wait(500); This is quite unfortunate. There must be a ...
7 years, 8 months ago (2013-04-12 14:37:36 UTC) #3
Tom Ball
https://codereview.chromium.org/13939003/diff/4001/runtime/vm/isolate.cc File runtime/vm/isolate.cc (right): https://codereview.chromium.org/13939003/diff/4001/runtime/vm/isolate.cc#newcode904 runtime/vm/isolate.cc:904: if (is_main_isolate && result == NULL) { On 2013/04/12 ...
7 years, 8 months ago (2013-04-16 18:11:02 UTC) #4
Ivan Posva
LGTM with comment. -Ivan https://codereview.chromium.org/13939003/diff/11001/runtime/vm/isolate.cc File runtime/vm/isolate.cc (right): https://codereview.chromium.org/13939003/diff/11001/runtime/vm/isolate.cc#newcode893 runtime/vm/isolate.cc:893: ml.Wait(); Please wait with a ...
7 years, 8 months ago (2013-04-16 19:09:19 UTC) #5
Tom Ball
https://codereview.chromium.org/13939003/diff/11001/runtime/vm/isolate.cc File runtime/vm/isolate.cc (right): https://codereview.chromium.org/13939003/diff/11001/runtime/vm/isolate.cc#newcode893 runtime/vm/isolate.cc:893: ml.Wait(); On 2013/04/16 19:09:19, Ivan Posva wrote: > Please ...
7 years, 8 months ago (2013-04-16 20:40:23 UTC) #6
Tom Ball
7 years, 8 months ago (2013-04-16 20:41:02 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 manually as r21573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698