Issue 13934019: Revert "With the collections deriving from ListBase, we no longer need to implement a number of boi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13934019: Revert "With the collections deriving from ListBase, we no longer need to implement a number of boi… (Closed)

Created:
7 years, 8 months ago by blois

Modified:
7 years, 8 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "With the collections deriving from ListBase, we no longer need to implement a number of boiler-plate methods." This reverts commit http://code.google.com/p/dart/source/detail?r=21848. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21852

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1090 lines, -154 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	16 chunks	+333 lines, -16 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	16 chunks	+333 lines, -16 lines	0 comments	Download
M	sdk/lib/html/html_common/filtered_element_list.dart	View	4 chunks	+84 lines, -5 lines	0 comments	Download
M	tests/html/element_test.dart	View	4 chunks	+7 lines, -39 lines	0 comments	Download
M	tests/html/node_test.dart	View	2 chunks	+0 lines, -62 lines	0 comments	Download
M	tools/dom/src/WrappedList.dart	View	5 chunks	+83 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	9 chunks	+212 lines, -7 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View	2 chunks	+38 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

blois

7 years, 8 months ago (2013-04-22 22:54:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r21852 (presubmit successful).