Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 13932018: Run constant propagation one more time after canonicalization so that following code can always ret… (Closed)

Created:
7 years, 8 months ago by srdjan
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Run constant propagation one more time after canonicalization so that following code can always return true: foo() { var a = new List(0); return a.isEmpty(); } Committed: https://code.google.com/p/dart/source/detail?r=21489

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M runtime/vm/compiler.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
srdjan
The code for allocating growable array (var a = []) is now simpler.
7 years, 8 months ago (2013-04-12 17:51:03 UTC) #1
srdjan
On 2013/04/12 17:51:03, srdjan wrote: > The code for allocating growable array (var a = ...
7 years, 8 months ago (2013-04-12 18:45:54 UTC) #2
Vyacheslav Egorov (Google)
LGTM I am starting to wonder if we just need to have an optimization fix ...
7 years, 8 months ago (2013-04-15 11:27:32 UTC) #3
srdjan
7 years, 8 months ago (2013-04-15 18:06:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r21489 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698