Issue 13932009: Check for conditionals used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13932009: Check for conditionals used. (Closed)

Created:
7 years, 8 months ago by Anton Muhin

Modified:
7 years, 8 months ago

Reviewers:
Mads Ager (google), blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Check for conditionals used. There should be nor unused conditionals, nor unknown ones. R=ager@google.com, blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=21421

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -198 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+0 lines, -79 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+0 lines, -80 lines	0 comments	Download
M	tools/dom/scripts/databasebuilder.py	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/fremontcutbuilder.py	View	1	5 chunks	+51 lines, -39 lines	0 comments	Download

Total messages: 5 (0 generated)

Anton Muhin

PTAL as I had to rework it notably: actually battery API is disabled in Chromium/Blink.

7 years, 8 months ago (2013-04-12 15:46:39 UTC) #3

Anton Muhin

7 years, 8 months ago (2013-04-15 08:28:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r21421 (presubmit successful).